Refactoring and adding user_groups to tenant#show #105

4 files changed, 36 insertions, 24 deletions

diff --git a/app/views/tenants/_admin_area.de.html.haml b/app/views/tenants/_admin_area.de.html.haml
index beab94e..89e14cb 100644
--- a/app/views/tenants/_admin_area.de.html.haml
+++ b/app/views/tenants/_admin_area.de.html.haml
@@ -30,6 +30,10 @@
 %h2 Admin Bereich
 = render :partial => 'tenants/sip_accounts_and_phones', :locals => {:tenant => @tenant}
 
+- if @tenant.user_groups.any?
+  %h2 Gruppen
+  = render "user_groups/index_core", :user_groups => @tenant.user_groups
+
 %h2 Features
 = render :partial => 'tenants/table_of_functions', :locals => {:tenant => @tenant}
 
diff --git a/app/views/tenants/_admin_area.html.haml b/app/views/tenants/_admin_area.html.haml
index 65810e7..7136f1e 100644
--- a/app/views/tenants/_admin_area.html.haml
+++ b/app/views/tenants/_admin_area.html.haml
@@ -29,6 +29,10 @@
 %h2 Admin Area
 = render :partial => 'tenants/sip_accounts_and_phones', :locals => {:tenant => @tenant}
 
+- if @tenant.user_groups.any?
+  %h2 Groups
+  = render "user_groups/index_core", :user_groups => @tenant.user_groups
+
 %h2 Features
 = render :partial => 'tenants/table_of_functions', :locals => {:tenant => @tenant}
 
diff --git a/app/views/user_groups/_index_core.html.haml b/app/views/user_groups/_index_core.html.haml
index d2b6e88..481a507 100644
--- a/app/views/user_groups/_index_core.html.haml
+++ b/app/views/user_groups/_index_core.html.haml
@@ -1,24 +1,28 @@
-%table
-  %tr
-    %th= t('user_groups.index.name')
-    %th= t('user_groups.index.description')
-    - if @user
-      %th= t('user_groups.index.tenant_id')
-    - else
-      %th= t('user_groups.index.members')
-
-  - reset_cycle
-  - for user_group in user_groups
-    %tr{:class => cycle('odd', 'even')}
-      %td= user_group.name
-      %td= user_group.description
+- cache(['user_groups_table', I18n.locale, current_user, @user, user_groups, User.order(:updated_at).last, User.count, UserGroupMembership.count, GsParameter.get('NUMBER_OF_SHOWN_ITEMS')]) do
+  %table
+    %tr
+      %th= t('user_groups.index.name')
+      - if user_groups.pluck(:description).uniq != [nil]
+        %th= t('user_groups.index.description')
       - if @user
-        %td= user_group.tenant
+        %th= t('user_groups.index.tenant_id')
       - else
-        %td
-          =render 'users/listing', :users => user_group.users
-          - if user_group.users.count > 1
-            %br
-          = render :partial => 'shared/create_link', :locals => {:parent => user_group, :child_class => UserGroupMembership}
+        %th= t('user_groups.index.members')
+
+    - reset_cycle
+    - for user_group in user_groups
+      %tr{:class => cycle('odd', 'even')}
+        %td= user_group.name
+        - if user_groups.pluck(:description).uniq != [nil]
+          %td= user_group.description
+        - if @user
+          %td= user_group.tenant
+        - else
+          %td
+            =render 'users/listing', :users => user_group.users
+            - if user_group.users.any?
+              %br
+            - if (user_group.tenant.user_ids - user_group.user_ids).any?
+              = render :partial => 'shared/create_link', :locals => {:parent => user_group, :child_class => UserGroupMembership}
 
-      =render :partial => 'shared/index_view_edit_destroy_part', :locals => {:parent => user_group.tenant, :child => user_group}
+        =render :partial => 'shared/index_view_edit_destroy_part', :locals => {:parent => user_group.tenant, :child => user_group}
diff --git a/app/views/users/_listing.html.haml b/app/views/users/_listing.html.haml
index 0a97ad1..9b7b653 100644
--- a/app/views/users/_listing.html.haml
+++ b/app/views/users/_listing.html.haml
@@ -1,8 +1,8 @@
 - amount_of_users = users.count
 - if amount_of_users > 0
-  - if amount_of_users < 30
+  - if amount_of_users < GsParameter.get('NUMBER_OF_SHOWN_ITEMS')
     = users.map{|user| user}.join(', ')
   - else
-    = users.limit(15).map{|user| user}.join(', ') + ', '
+    = users.limit((GsParameter.get('NUMBER_OF_SHOWN_ITEMS') / 2).floor).map{|user| user}.join(', ') + ', '
     = '[...]'
-    = users.offset(amount_of_users - 15).map{|user| user}.join(', ')
\ No newline at end of file
+    = users.offset(amount_of_users - (GsParameter.get('NUMBER_OF_SHOWN_ITEMS') / 2).floor).map{|user| user}.join(', ')
\ No newline at end of file